Skip to content
This repository was archived by the owner on May 18, 2020. It is now read-only.

Install plugin with --batch option in Elasticsearch 5.x or later#59

Merged
gaczm merged 1 commit intoallegro:masterfrom
pukkaone:batch
Jul 12, 2018
Merged

Install plugin with --batch option in Elasticsearch 5.x or later#59
gaczm merged 1 commit intoallegro:masterfrom
pukkaone:batch

Conversation

@pukkaone
Copy link
Copy Markdown
Contributor

@pukkaone pukkaone commented Jul 3, 2018

This mitigates breaking change elastic/elasticsearch#29359 introduced in Elasticsearch 6.3.0.

Before Elasticsearch 6.3.0, if a plugin requires additional permissions, and standard input is closed or there is no console, then the plugin is installed without asking the user to acknowledge the additional permissions. Elasticsearch 6.3.0 introduced a breaking change where it waits for the user to acknowledge, so an attempt to install such a plugin hangs forever. Elasticsearch 5.x introduced the --batch option to install the plugin without asking the user to acknowledge.

Before Elasticsearch 6.3.0, if a plugin requires additional permissions,
and standard input is closed or there is no console, then the plugin is
installed without asking the user to acknowledge the additional
permissions. Elasticsearch 6.3.0 introduced a breaking change where it
waits for the user to acknowledge, unless the install command is run
with the --batch option. Elasticsearch 5.x introduced this option.
@gaczm gaczm merged commit bd6548c into allegro:master Jul 12, 2018
@gaczm
Copy link
Copy Markdown
Contributor

gaczm commented Jul 12, 2018

Hi, thanks for contribution. Code looks ok, I'm merging this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants