This repository was archived by the owner on May 18, 2020. It is now read-only.
Install plugin with --batch option in Elasticsearch 5.x or later#59
Merged
gaczm merged 1 commit intoallegro:masterfrom Jul 12, 2018
pukkaone:batch
Merged
Install plugin with --batch option in Elasticsearch 5.x or later#59gaczm merged 1 commit intoallegro:masterfrom pukkaone:batch
gaczm merged 1 commit intoallegro:masterfrom
pukkaone:batch
Conversation
Before Elasticsearch 6.3.0, if a plugin requires additional permissions, and standard input is closed or there is no console, then the plugin is installed without asking the user to acknowledge the additional permissions. Elasticsearch 6.3.0 introduced a breaking change where it waits for the user to acknowledge, unless the install command is run with the --batch option. Elasticsearch 5.x introduced this option.
Contributor
|
Hi, thanks for contribution. Code looks ok, I'm merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mitigates breaking change elastic/elasticsearch#29359 introduced in Elasticsearch 6.3.0.
Before Elasticsearch 6.3.0, if a plugin requires additional permissions, and standard input is closed or there is no console, then the plugin is installed without asking the user to acknowledge the additional permissions. Elasticsearch 6.3.0 introduced a breaking change where it waits for the user to acknowledge, so an attempt to install such a plugin hangs forever. Elasticsearch 5.x introduced the
--batchoption to install the plugin without asking the user to acknowledge.